RFR: 8339113: AccessFlags can be u2 in metadata [v2]

[Coleen Phillimore]

On Thu, 19 Dec 2024 13:48:16 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>    
>>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>>  - Update src/hotspot/share/opto/library_call.cpp
>>    
>>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>
> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 823:
> 
>> 821:   {
>> 822:     Label done;
>> 823:     __ load_unsigned_short(r0, access_flags);
> 
> Could you please use `ldrh` rather than `load_unsigned_short` here? `load_unsigned_short` is only used in the termplate interpreter, and is a hangover from the hand-translation from x86.

Oh, I thought it was quite nice that I didn't have to know the ldrh instruction as a platform independent load_unsigned_short was available.  I can change it in the aarch64 code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1893073141