RFR: 8324833: Signed integer overflows in ABS [v2]

[Dean Long]

On Wed, 31 Jan 2024 15:55:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the details in the bug. I think current `ABS` implementation is beyond repair, and we should just switch to `uabs`.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug, `all` with `-ftrapv` (now fully passes!)
>>  - [x] Linux x86_64 fastdebug, `all`
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unnecessary comment

This seems to introduce a lot of potential warnings if -Wsigned-conversion is ever enabled.  Use of checked_cast() could solve this, but I only see it used in one place.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17617#issuecomment-1922190550