RFR: 8325082: Rename headers named 'heapRegion*' of G1 [v2]

Stefan Karlsson stefank at openjdk.org
Mon Feb 12 08:22:54 UTC 2024


On Sun, 11 Feb 2024 13:10:52 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

>> 8325082: Rename headers named 'heapRegion*' of G1
>
> Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reorder some headers

Looks good to me. There's just a few sort-order issues that needs to be fixed. Please, wait for one of the G1 devs to also review the patch.

src/hotspot/share/gc/g1/g1HeapRegion.hpp line 31:

> 29: #include "gc/g1/g1HeapRegionTracer.hpp"
> 30: #include "gc/g1/g1HeapRegionType.hpp"
> 31: #include "gc/g1/g1HeapRegionTraceType.hpp"

Sort order needs to be fixed here.

src/hotspot/share/gc/g1/g1RemSet.cpp line 38:

> 36: #include "gc/g1/g1HeapRegion.inline.hpp"
> 37: #include "gc/g1/g1HeapRegionManager.inline.hpp"
> 38: #include "gc/g1/g1HeapRegionRemSet.inline.hpp"

Sort order. Should go after g1GC.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17666#pullrequestreview-1874702381
PR Review Comment: https://git.openjdk.org/jdk/pull/17666#discussion_r1485846549
PR Review Comment: https://git.openjdk.org/jdk/pull/17666#discussion_r1485847673


More information about the graal-dev mailing list