RFR: 8324833: Signed integer overflows in ABS [v4]
Aleksey Shipilev
shade at openjdk.org
Wed Feb 21 20:05:12 UTC 2024
> See the details in the bug. I think current `ABS` implementation is beyond repair, and we should just switch to `uabs`.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, `all` with `-ftrapv` (now fully passes!)
> - [x] Linux x86_64 fastdebug, `all`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
- Review comments
- Merge branch 'master' into JDK-8324833-uabs
- Touchups
- Unnecessary comment
- Also handle the -stride_con with proper uabs
- Another attempt at JVMCI fix
- Work
- Cleaner version
- Merge branch 'master' into JDK-8324833-uabs
- Rewrite JVMCI usage to avoid the messy overload
- ... and 1 more: https://git.openjdk.org/jdk/compare/7090bd75...272fb16b
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17617/files
- new: https://git.openjdk.org/jdk/pull/17617/files/96a1987c..272fb16b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17617&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17617&range=02-03
Stats: 43512 lines in 1367 files changed: 21343 ins; 13810 del; 8359 mod
Patch: https://git.openjdk.org/jdk/pull/17617.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17617/head:pull/17617
PR: https://git.openjdk.org/jdk/pull/17617
More information about the graal-dev
mailing list