RFR: 8324833: Signed integer overflows in ABS [v3]

Aleksey Shipilev shade at openjdk.org
Wed Feb 21 20:05:12 UTC 2024


On Fri, 2 Feb 2024 23:47:33 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Touchups
>
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 1062:
> 
>> 1060:   if (target_addr != 0x0) {
>> 1061:     jlong off_low = (jlong)target_addr - ((jlong)CodeCache::low_bound() + sizeof(int));
>> 1062:     jlong off_high = (jlong)target_addr - ((jlong)CodeCache::high_bound() + sizeof(int));
> 
> Suggestion:
> 
>     jlong off_low = (jlong)(target_addr - (CodeCache::low_bound() + sizeof(int)));
>     jlong off_high = (jlong)(target_addr - (CodeCache::high_bound() + sizeof(int)));

Done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17617#discussion_r1498230649


More information about the graal-dev mailing list