RFR: 8336103: Sharper checks for <init> and <clinit> initializers [v3]

[Aleksey Shipilev]

On Fri, 12 Jul 2024 09:17:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> All around Hotspot, we have calls to `method->is_initializer()`. That methods test for both instance and static initializers. In many cases, the uses imply we actually want to test for constructor (instance initializer), not static initializer. Sometimes we filter explicitly for `!m->is_static()`, sometimes we don't. Often we get lucky by never being exposed to static initializers on particular paths.
>> 
>> I would like to sharpen this. I went back and forth, and ultimately decided to remove `is_initializer` completely to avoid future confusion, and rewrite the uses appropriately.
>> 
>> Additional testing:
>>  - [x] Linux AArch64 server fastdebug, `all` (includes Fuzzer and CTW tests)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Touch up assert messages

Putting back to draft until the behavioral changes are done in separate sub-tasks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20120#issuecomment-2230671038