RFR: 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported

Doug Simon dnsimon at openjdk.org
Tue Jun 18 10:29:11 UTC 2024


On Mon, 17 Jun 2024 16:20:09 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

> Implement `JVMCICompiler::is_intrinsic_supported` by consulting `jdk/vm/ci/runtime/JVMCICompiler.isIntrinsicSupported`. This enables WhiteBox-based tests that depend on the result of this method, e.g., `compiler/codegen/aes/TestAESMain.java`, on Graal.

Marked as reviewed by dnsimon (Reviewer).

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotVMConfigStore.java line 92:

> 90:             // valid intrinsicID starts from 1
> 91:             VMIntrinsicMethod intrinsic = vmIntrinsics.get(intrinsicID - 1);
> 92:             // We assume vmIntrinsics are sorted by ID

"We assume vmIntrinsics" -> "We speculate that vmIntrinsics"

-------------

PR Review: https://git.openjdk.org/jdk/pull/19753#pullrequestreview-2125126510
PR Review Comment: https://git.openjdk.org/jdk/pull/19753#discussion_r1644220642


More information about the graal-dev mailing list