RFR: 8341411: C2: remove slice parameter from GraphKit::make_load() and GraphKit::store_to_memory()

Tobias Hartmann thartmann at openjdk.org
Wed Nov 6 08:04:30 UTC 2024


On Fri, 1 Nov 2024 14:50:31 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

> This patch removes the address type from `GraphKit::make_load()` and `GraphKit::store_to_memory()`
> 
> As https://github.com/openjdk/jdk/pull/21303 introduced asserts that check that the address type agrees with  `C->get_alias_index(_gvn.type(adr)->isa_ptr()`, passing the address type is redundant and it can be computed internally from the address.

Looks good to me. @rwestrel who proposed the change, should also have a look.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21834#pullrequestreview-2417492275


More information about the graal-dev mailing list