RFR: 8341411: C2: remove slice parameter from GraphKit::make_load() and GraphKit::store_to_memory() [v2]

theoweidmannoracle duke at openjdk.org
Thu Nov 7 10:14:03 UTC 2024


On Wed, 6 Nov 2024 12:19:16 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary store_to_memory param/overload
>
> src/hotspot/share/gc/shared/c2/barrierSetC2.cpp line 220:
> 
>> 218:       load = kit->gvn().transform(load);
>> 219:     } else {
>> 220:       load = kit->make_load(control, adr, val_type, access.type(), adr_type, mo,
> 
> No similar change to `BarrierSetC2::store_at_resolved()`?

I missed that. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21834#discussion_r1832411316


More information about the graal-dev mailing list