RFR: 8341411: C2: remove slice parameter from GraphKit::make_load() and GraphKit::store_to_memory() [v5]

Tobias Hartmann thartmann at openjdk.org
Wed Nov 13 13:17:13 UTC 2024


On Fri, 8 Nov 2024 09:16:03 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

>> This patch removes the address type from `GraphKit::make_load()` and `GraphKit::store_to_memory()`
>> 
>> As https://github.com/openjdk/jdk/pull/21303 introduced asserts that check that the address type agrees with  `C->get_alias_index(_gvn.type(adr)->isa_ptr()`, passing the address type is redundant and it can be computed internally from the address.
>
> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix asserts

Marked as reviewed by thartmann (Reviewer).

Looks good to me too.

> Do we want to file a bug about to, at least, give it a try?

Sounds reasonable, let's file a follow-up RFE for this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21834#pullrequestreview-2433070180
PR Comment: https://git.openjdk.org/jdk/pull/21834#issuecomment-2473586328


More information about the graal-dev mailing list