RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

[Coleen Phillimore]

On Sat, 16 Nov 2024 02:41:59 GMT, John R Rose <jrose at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>> 
>>  - Handle merge conflicts in new resolve_instance_class calls.
>>  - Merge branch 'master' into protection-domain
>>  - Purge last references to SecurityManager.
>>  - More obsolete code.  Fix trace_class_resolution (doesn't throw exception - shouldn't take TRAPS).
>>  - Found more obsolete security manager code.
>>  - More purging of AccessController, AccessControlContext and some stackwalking questions.
>>  - David comments.
>>  - Remove some more includes.
>>  - 8341916: Remove ProtectionDomain related hotspot code and tests
>
> src/hotspot/share/classfile/systemDictionary.hpp line 41:
> 
>> 39: // represented as null.
>> 40: 
>> 41: // The underlying data structure is an concurrent hash table (Dictionary) per
> 
> typo: s/an concurrent/a concurrent/

Fixed.

> src/hotspot/share/classfile/systemDictionary.hpp line 245:
> 
>> 243:   // compute java_mirror (java.lang.Class instance) for a type ("I", "[[B", "LFoo;", etc.)
>> 244:   // Either the accessing_klass or the CL can be non-null, but not both.
>> 245:   // Callee will fill in CL from the accessing klass, if they are needed.
> 
> The two comment lines ("Either … Callee …") should be one line:
> 
> 
> + // Callee will fill in CL from the accessing klass, if the CL is needed.

One line would be too long and the comment doesn't make any sense anyway. The accessing_klass is never null and the callee doesn't do anything with the class loader, ie it doesn't pass it in.   So I deleted the last two comment lines.   We should clean this up later to reflect reality.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1844986641
PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1844986893