RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v5]

David Holmes dholmes at openjdk.org
Tue Nov 19 07:08:53 UTC 2024


On Mon, 18 Nov 2024 12:39:32 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I don't see any difference in the callers in relation to this PR and the function is not presently declared `extern`. ??
>
> There was an extern trace_class_resolution() function that called this _impl function that I removed, so renamed this impl function to trace_class_resolution().
> It's declared extern in jvm.hp file, and this 'extern' qualifier is added so it's easy to see that this is used externally.

Sorry but not seeing that. It is declared in `jvm_misc.hpp` but not as `extern`. The original version was not `extern`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1847747913


More information about the graal-dev mailing list