RFR: 8329597: C2: Intrinsify Reference.clear [v3]
Kim Barrett
kbarrett at openjdk.org
Tue Oct 1 01:30:37 UTC 2024
On Mon, 30 Sep 2024 16:45:12 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 420:
>>
>>> 418: /* Implementation of clear(), also used by enqueue(). A simple
>>> 419: * assignment of the referent field won't do for some garbage
>>> 420: * collectors.
>>
>> Description of clear0 is rendered stale by this change. The first sentence is no longer true, since it's now
>> clearImpl that has that role. The second sentence probably ought to also be moved into the description of
>> clearImpl.
>
> Thanks! I tightened up comments a bit, take another look?
Yes, that's better. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20139#discussion_r1782006243
More information about the graal-dev
mailing list