RFR: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class [v2]

[Stefan Karlsson]

On Thu, 3 Oct 2024 11:42:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Move NONCOPYABLE
>>  - Move VMStructs fields out of the CPU files
>>  - Add comment to the include of the platform specific class
>
> src/hotspot/os_cpu/bsd_aarch64/vmStructs_bsd_aarch64.hpp line 40:
> 
>> 38:   /******************************/                                                                                                   \
>> 39:   nonstatic_field(OSThread,                      _thread_id,                                      OSThread::thread_id_t)             \
>> 40:   nonstatic_field(OSThread,                      _unique_thread_id,                               uint64_t)
> 
> Does the SA actually use these?  I don't see any SA changes in this patch.  If it doesn't, we should remove it until there is someone that might add support for this.  We're not enhancing the SA at this point.

I think the SA is using these. There are references to them in the various SA files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21306#discussion_r1786170685