RFR: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread [v2]
Tomáš Zezula
duke at openjdk.org
Fri Oct 4 15:04:49 UTC 2024
> [JDK-8318694](https://bugs.openjdk.org/browse/JDK-8318694) limited the ability for JVMCI CompilerThreads to make Java upcalls. This is to mitigate against deadlock when an upcall does class loading. Class loading can easily create deadlock situations in -Xcomp or -Xbatch mode.
>
> However, for Truffle, upcalls are unavoidable if Truffle partial evaluation occurs as part of JIT compilation inlining. This occurs when the Graal inliner sees a constant Truffle AST node which allows a Truffle-specific inlining extension to perform Truffle partial evaluation (PE) on the constant. Such PE involves upcalls to the Truffle runtime (running in Java).
>
> This PR provides the escape hatch such that Truffle specific logic can put a compiler thread into "allow Java upcall" mode during the scope of the Truffle logic.
Tomáš Zezula has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
- Libgraal does not allow _can_call_java.
- rename changeCompilerThreadCanCallJava to updateCompilerThreadCanCallJava
- added CompilerThreadCanCallJavaScope
-------------
Changes: https://git.openjdk.org/jdk/pull/21285/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21285&range=01
Stats: 132 lines in 6 files changed: 116 ins; 4 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/21285.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21285/head:pull/21285
PR: https://git.openjdk.org/jdk/pull/21285
More information about the graal-dev
mailing list