RFR: 8339783: Implementation of JEP 479: Remove the Windows 32-bit x86 Port [v6]

Tue Oct 29 15:11:27 UTC 2024

On Tue, 29 Oct 2024 09:02:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove windows-only code guarded by _LP64.
>
> src/hotspot/os/windows/os_windows.cpp line 2615:
> 
>> 2613:   Thread* t = Thread::current_or_null_safe();
>> 2614: 
>> 2615: #if defined(_M_AMD64)
> 
> The check for LP64 on line 2622 below seems redundant now

Indeed, nice catch! I also found another place in this file that were guarded by `_LP64` that I removed. I also did a grep on `LP64` in `hotspot/os/windows`, but there were no more instances.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820994278