RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v13]
    Aleksey Shipilev 
    shade at openjdk.org
       
    Wed Oct 30 12:14:18 UTC 2024
    
    
  
On Tue, 29 Oct 2024 20:22:03 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>> 
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
I am basically okay with this PR. Only a few leftover comments.
make/hotspot/gensrc/GensrcAdlc.gmk line 50:
> 48:     ADLC_CFLAGS := -nologo -EHsc
> 49:     ADLC_CFLAGS_WARNINGS := -W3 -D_CRT_SECURE_NO_WARNINGS \
> 50:          -D_CRT_DECLARE_NONSTDC_NAMES -D_CRT_NONSTDC_NO_WARNINGS
Not clear why do we need these new warnings? I don't right away see anything in ADLC that needs it.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21744#pullrequestreview-2404648390
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822494914
    
    
More information about the graal-dev
mailing list