RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v16]
Coleen Phillimore
coleenp at openjdk.org
Wed Oct 30 19:38:36 UTC 2024
On Tue, 29 Oct 2024 23:16:29 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1411:
>
>> 1409: // zero out fields (but not the stack)
>> 1410: const size_t hs = oopDesc::header_size();
>> 1411: oopDesc::set_klass_gap(mem, 0);
>
> Why, bug fix or cleanup?
This might confuse the change for JEP 450 since with CompactObjectHeaders there's no klass_gap, so depending on which change goes first, there will be conditional code here. Good question though, it looks like we only ever want to copy the payload of the object.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823227312
More information about the graal-dev
mailing list