RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v12]
Ferenc Rakoczi
duke at openjdk.org
Wed Apr 2 07:45:14 UTC 2025
On Tue, 1 Apr 2025 22:43:36 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reacting to comments by Volodymyr.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 359:
>
>> 357: __ kmovbl(k4, rax);
>> 358: __ addl(rax, 16);
>> 359: __ kmovbl(k5, rax);
>
> We could use the sequence from generate_sha3_implCompress to setup the K registers, that has less dependency:
>
> __ movl(rax, 0x1F);
> __ kmovbl(k5, rax);
> __ kshiftrbl(k4, k5, 1);
> __ kshiftrbl(k3, k5, 2);
> __ kshiftrbl(k2, k5, 3);
> __ kshiftrbl(k1, k5, 4);
Thanks! (I had copied/doubled this function from the single state version before you made me do this change on that one and I forgot to update the copy :-) ) Changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r2024255339
More information about the graal-dev
mailing list