RFR: 8352645: Add tool support to check order of includes [v6]

Kim Barrett kbarrett at openjdk.org
Wed Apr 2 17:11:58 UTC 2025


On Tue, 1 Apr 2025 15:35:45 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> test/hotspot/jtreg/TEST.groups line 142:
>> 
>>> 140: 
>>> 141: tier1_common = \
>>> 142:   sources \
>> 
>> I don't understand this change.  How does this end up doing anything different than before?
>
> This makes `sources` be tested in GHA: https://github.com/openjdk/jdk/blob/a1ab1d8de411aace21decd133e7e74bb97f27897/.github/workflows/test.yml#L88
> 
> An alternative would be to add a separate GHA jobs just for `sources`:
> 
>           - test-name: 'hs/tier1 sources'
>             test-suite: 'test/hotspot/jtreg/:tier1_sources'
>             debug-suffix: -debug
> 
> Given how small `sources` is ([currently only 1 test](https://github.com/openjdk/jdk/tree/master/test/hotspot/jtreg/sources)), it felt like it should just be folded into common.

Ah, the workflows definition is what I was having trouble finding. I
understand now. In light of that, the proposed change to the groups looks
fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24247#discussion_r2025256054


More information about the graal-dev mailing list