RFR: 8352724: Verify bounds for primitive array reads in JVMCI [v2]

[Andrej Pečimúth]

On Mon, 14 Apr 2025 14:39:35 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Andrej Pečimúth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test reads after last array element in JVMCI.
>
> test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestConstantReflectionProvider.java line 148:
> 
>> 146:             if (cv.boxed != null && cv.boxed.getClass().isArray()) {
>> 147:                 JavaKind kind = metaAccess.lookupJavaType(cv.value).getComponentType().getJavaKind();
>> 148:                 long offset = metaAccess.getArrayBaseOffset(kind) + (long) metaAccess.getArrayIndexScale(kind) * Array.getLength(cv.boxed);
> 
> If I understand correctly, this tests a read of an element one past the end of the array.
> Can you please also add a test for a read that is partially out-of-bounds:
> 
> long offset = 1 + metaAccess.getArrayBaseOffset(kind) + (long) metaAccess.getArrayIndexScale(kind) * (Array.getLength(cv.boxed) - 1);

I added a test for a `long` read from `array[array.index - 1]` because adding `+ 1` would make the read unaligned (which is also not allowed).  Please check it out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24200#discussion_r2042506762