RFR: 8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2" [v2]

[Coleen Phillimore]

On Mon, 14 Apr 2025 20:10:33 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Please, review this trivial PR to set more meaningful names for `get_vm_result*`.
>> 
>> I tested the best I could on OSX AArch64 & Linux amd64 with JTREG tier1-3.
>> The other platforms I tested by cross-compiling. If you can run some tests on those platform I'd appreciate.
>
> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Fix merge conflicts
>  - Rename get_vm_result and get_vm_result_2 to more meaningfult names.

I like this change. vm_result_2 for metadata result was never a good name.

src/hotspot/share/runtime/vmStructs.cpp line 610:

> 608:   nonstatic_field(JavaThread,                  _anchor,                                       JavaFrameAnchor)                       \
> 609:   nonstatic_field(JavaThread,                  _vm_result_oop,                                oop)                                   \
> 610:   nonstatic_field(JavaThread,                  _vm_result_metadata,                           Metadata*)                             \

Delete these two lines.  They're not used by the Serviceability Agent.  And shouldn't be used.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24632#pullrequestreview-2767963168
PR Review Comment: https://git.openjdk.org/jdk/pull/24632#discussion_r2044352921