RFR: 8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2" [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Apr 16 18:44:49 UTC 2025


On Tue, 15 Apr 2025 13:41:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Fix merge conflicts
>>  - Rename get_vm_result and get_vm_result_2 to more meaningfult names.
>
> src/hotspot/share/runtime/javaThread.hpp line 788:
> 
>> 786:   // Oop results of vm runtime calls
>> 787:   oop  vm_result_oop() const                     { return _vm_result_oop; }
>> 788:   void set_vm_result_oop(oop x)                  { _vm_result_oop   = x; }
> 
> Suggestion:
> 
>   void set_vm_result_oop(oop x)                  { _vm_result_oop = x; }

I don't think John fixed the space here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24632#discussion_r2047509566


More information about the graal-dev mailing list