RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v11]
Andrew Dinn
adinn at openjdk.org
Thu Apr 17 09:51:04 UTC 2025
On Thu, 17 Apr 2025 09:40:02 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 717:
>>
>>> 715: desc_len = (int)strlen(_cpu_desc);
>>> 716: snprintf(_cpu_desc + desc_len, CPU_DETAILED_DESC_BUF_SIZE - desc_len, " %s", _features_string);
>>> 717: fprintf(stderr, "_features_string = \"%s\"", _features_string);
>>
>> Was this line added by mistake? Looks like a leftover.
>
> @iwanowww Oooops, yes. Addressed in [https://github.com/openjdk/jdk/pull/24717](https://github.com/openjdk/jdk/pull/24717) together with another forgotten (though not strictly necessary) change. Thanks for catching it!
> Could you review that (really short) PR?
@ferakocz That link has the right label but leads to the wrong place. It should point [here](https://github.com/openjdk/jdk/pull/24717).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23663#discussion_r2048618862
More information about the graal-dev
mailing list