RFR: 8339113: AccessFlags can be u2 in metadata [v5]

Martin Doerr mdoerr at openjdk.org
Thu Jan 2 13:55:36 UTC 2025


On Thu, 2 Jan 2025 13:05:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149:
>> 
>>> 147:     // _access_flags must be a 16 bit value.
>>> 148:     assert(sizeof(AccessFlags) == 2, "wrong size");
>>> 149:     __ lha(R11_scratch1/*access_flags*/, method_(access_flags));
>> 
>> Using `lhz` would be more consistent. `lha` uses sign extend instead of zero extend. Feel free to clean this up if you want. Both instructions should work.
>
> I fixed this - it was the only one.

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1900899700


More information about the graal-dev mailing list