RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]
Kim Barrett
kbarrett at openjdk.org
Sat Jan 4 10:28:36 UTC 2025
On Fri, 3 Jan 2025 13:24:53 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> I really like the syntactic change of this feature, and it's very nice that we get to have working auto-complete (makes it easier to find out that a specific function isn't forbidden). The syntactic change isn't shown in the PR description, isn't that useful to add?
Isn't the last paragraph of the PR description (beginning with "Some of the poisoned functions...") what your are
looking for? Admittedly I didn't mention working with auto-complete as one of the benefits.
> I have a bike shedding request: Could we skip the S at the end and have it be `permit_forbidden_function::free(my_ptr);`? We only allow one forbidden function in that call, so this reads neater.
I named it as a collection of forbidden functions. But I agree it reads better without the plural, so I've removed the S.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22890#issuecomment-2571175973
More information about the graal-dev
mailing list