RFR: 8339113: AccessFlags can be u2 in metadata [v11]
Vladimir Ivanov
vlivanov at openjdk.org
Tue Jan 7 06:13:48 UTC 2025
On Mon, 6 Jan 2025 13:47:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Yes, we are.
>
> I had a little experiment.
>
> extern "C" int printf(const char *,...);
> int main() {
> unsigned short ss = 0x8000;
> printf("does unsigned sign extend to int? %d\n", int(ss));
> }
IMO you could just call `as_int()` here. All other usages of `ciFlags::as_int()` are in printing code.
Ideally, `ciField::print()` could use `ciFlags::print()`, but such cleanup can be done separately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1904950560
More information about the graal-dev
mailing list