RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

Kim Barrett kbarrett at openjdk.org
Thu Jan 9 06:34:49 UTC 2025


On Wed, 8 Jan 2025 13:23:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I disagree. It seems to me that breaking the abstraction like that is just asking for trouble.
>
> Yes, I think it's fine to say !WINDOWS instead of listing all the posix ports.  We've been avoiding dispatch files and once it reaches a threshold of too many #ifdef !WINDOWS #include posix.hpp one, then we could add another macro like the OS_CPU one.
> 
> Also the copyright script added 2025 for these because they started with 2024 so it's sort of a bug in the script but not really solvable because it doesn't know that you didn't check this in in 2024.

@coleenp The copyrights on the new files being 2024-2025 is intentional. They were first published (in this PR)
in 2024, so I think are supposed to have that starting year.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1908231286


More information about the graal-dev mailing list