RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v7]

Kim Barrett kbarrett at openjdk.org
Thu Jan 9 18:32:42 UTC 2025


On Thu, 9 Jan 2025 12:58:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   stefank whitespace suggestions
>
> src/hotspot/os/bsd/permitForbiddenFunctions_bsd.hpp line 30:
> 
>> 28: #include "permitForbiddenFunctions_posix.hpp"
>> 29: 
>> 30: #endif // OS_BSD_PERMITFORBIDDENFUNCTIONS_BSD_HPP
> 
> I thought you were eliminating these in favor of #ifdef where included?

Removed the forbid files, forgot the permit files.  Sigh!  I'll push a new commit after running tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1909272432


More information about the graal-dev mailing list