RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]
David Holmes
dholmes at openjdk.org
Mon Jan 13 02:36:43 UTC 2025
On Fri, 10 Jan 2025 13:00:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> @kimbarrett I understand. I also don't like the includer needing to know about this, and maybe it is time to add OS_FAMILY_HEADER to deal with it. But in the absence of the new macro I prefer this break of abstraction to the creation of a bunch of tiny forwarding files.
>
> I prefer the opposite. If you break these up into a bunch of forwarding files, do all the rest of the VM the same way.
>
> It may be my problem but I don't have a good IDE to have to navigate through a slew of similarly named files to find the real implementation.
@coleenp I thought you and I were on the same page not liking the creation of all these little files that just forward to the posix one. ???
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1912608160
More information about the graal-dev
mailing list