RFR: 8361842: Move input validation checks to Java for String-related intrinsics [v2]

[Volkan Yazici]

On Mon, 14 Jul 2025 10:27:45 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Minimize the number of touched lines in `vmIntrinsics.hpp`
>>  - Remove Markdown-styling in comments
>>  - Improve wording of the `VerifyIntrinsicChecks` flag
>
> src/hotspot/share/classfile/vmIntrinsics.hpp line 417:
> 
>> 415:                                                                                                                         \
>> 416:   do_class(java_lang_StringCoding,        "java/lang/StringCoding")                                                     \
>> 417:   do_intrinsic(_countPositives,           java_lang_StringCoding, countPositives_name, countPositives_signature,   F_S) \
> 
> It is a matter of taste but it might be better not to change the whitespaces (it might make searching for changes (and possibly backports) harder. The rest of the file is not too consistent anyway).

Fixed in 7c042b35.

I completely agree with your point. In fact, I'm opposed to _"vertical alignment"_ due to its obvious maintainability and version control hygiene issues. Alas, that is the existing style, and I tried to adhere to it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25998#discussion_r2208469532