RFR: 8361842: Move input validation checks to Java for String-related intrinsics [v6]

[Volkan Yazici]

On Thu, 10 Jul 2025 12:23:06 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Volkan Yazici has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Add test verifying the effectiveness of `VerifyIntrinsicChecks`
>
> src/hotspot/share/opto/library_call.cpp line 963:
> 
>> 961: 
>> 962:   if (bailout->req() > 1) {
>> 963:     if (halt) {
> 
> Toggle to force a VM crash to be used to surface intrinsic Java wrappers failing to spot invalid input.

@TobiHartmann, this change results in the following compiler error:


/home/vy/.../src/hotspot/share/opto/library_call.cpp:958:35: error: invalid conversion from 'Node*' to 'RegionNode*' [-fpermissive]
  958 |   generate_negative_guard(offset, bailout);
      |                                   ^~~~~~~
      |                                   |
      |                                   Node*


That is, `bailout` is supposed to be of type `RegionNode*`, but `_gvn.transform()` returns a value of type `Node*`. I will locally amend this change as


bailout = (RegionNode*) _gvn.transform(bailout);


Let me know if you disagree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25998#discussion_r2212232094