RFR: 8361842: Move input validation checks to Java for String-related intrinsics [v8]

[Volkan Yazici]

On Thu, 17 Jul 2025 07:04:00 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> @TobiHartmann, this change results in the following compiler error:
>> 
>> 
>> /home/vy/.../src/hotspot/share/opto/library_call.cpp:958:35: error: invalid conversion from 'Node*' to 'RegionNode*' [-fpermissive]
>>   958 |   generate_negative_guard(offset, bailout);
>>       |                                   ^~~~~~~
>>       |                                   |
>>       |                                   Node*
>> 
>> 
>> That is, `bailout` is supposed to be of type `RegionNode*`, but `_gvn.transform()` returns a value of type `Node*`. bfc301798d1 amends failing code with
>> 
>> 
>> bailout = (RegionNode*) _gvn.transform(bailout);
>> 
>> 
>> Let me know if you disagree.
>
> Please use `->as_Region()` instead.

Changed as requested in db1ed388765.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25998#discussion_r2212492666