RFR: 8362524: Fix confusing but harmless typos in x86 CPU Features [v2]

[Jan Kratochvil]

On Fri, 18 Jul 2025 00:23:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Call it DECLARE_CPU_FEATURE_NAME
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 50:
> 
>> 48: VM_Version::CpuidInfo VM_Version::_cpuid_info = { 0, };
>> 49: 
>> 50: #define DECLARE_CPU_FEATURE_FLAG(id, name, bit) name,
> 
> I think the "typo" here is in the `#undef` rather than the define.  Calling this `xxx_NAME` seems
> appropriate, since it is providing the name for the feature for collection in `_features_names[]`.
> Places that are using `xxx_FLAG` are constructing the enumerator for the feature. There is no
> requirement that all uses of an X-macro use the same name for the passed in macro, and indeed
> it is quite normal to not do so.

Yes but then this typo has happened. Anyway it is changed now, thanks for the review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26371#discussion_r2215092851