RFR: 8363837: Move StubRoutines::_crc_table_adr initialization to preuniverse stubs [v2]

[Vladimir Kozlov]

On Thu, 24 Jul 2025 13:23:26 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed Zero VM
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 420:
> 
>> 418:   static_field(StubRoutines,                _dilithiumDecomposePoly,                          address)                               \
>> 419:   static_field(StubRoutines,                _updateBytesCRC32,                                address)                               \
>> 420:   static_field(StubRoutines,                _crc_table_addr,                                  address)                               \
> 
> Could you please export via `CompilerToVM::Data`?
> 
> diff --git a/src/hotspot/share/jvmci/jvmciCompilerToVM.hpp b/src/hotspot/share/jvmci/jvmciCompilerToVM.hpp
> index 41531b083fc..71331b578a5 100644
> --- a/src/hotspot/share/jvmci/jvmciCompilerToVM.hpp
> +++ b/src/hotspot/share/jvmci/jvmciCompilerToVM.hpp
> @@ -131,6 +131,8 @@ class CompilerToVM {
>      static address dlog10;
>      static address dpow;
>  
> +    static address crc_table_addr;
> +
>      static address symbol_init;
>      static address symbol_clinit;
>  
> diff --git a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
> index b6d919fdfe9..8a1a02d62b3 100644
> --- a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
> +++ b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
> @@ -151,6 +151,8 @@ address CompilerToVM::Data::dlog;
>  address CompilerToVM::Data::dlog10;
>  address CompilerToVM::Data::dpow;
>  
> +address CompilerToVM::Data::crc_table_addr;
> +
>  address CompilerToVM::Data::symbol_init;
>  address CompilerToVM::Data::symbol_clinit;
>  
> @@ -289,6 +291,7 @@ void CompilerToVM::Data::initialize(JVMCI_TRAPS) {
>  
>    SET_TRIGFUNC_OR_NULL(dtanh);
>    SET_TRIGFUNC_OR_NULL(dcbrt);
> +  SET_TRIGFUNC_OR_NULL(crc_table_addr);
>  
>  #undef SET_TRIGFUNC_OR_NULL
>  
> diff --git a/src/hotspot/share/jvmci/vmStructs_jvmci.cpp b/src/hotspot/share/jvmci/vmStructs_jvmci.cpp
> index 1408cb09b0a..88d098468e9 100644
> --- a/src/hotspot/share/jvmci/vmStructs_jvmci.cpp
> +++ b/src/hotspot/share/jvmci/vmStructs_jvmci.cpp
> @@ -147,6 +147,7 @@
>    static_field(CompilerToVM::Data,             dlog,                                   address)                                      \
>    static_field(CompilerToVM::Data,             dlog10,                                 address)                                      \
>    static_field(CompilerToVM::Data,             dpow,                                   address)                                      \
> +  static_field(CompilerToVM::Data,             crc_table_addr,                         address)         ...

@mur47x111 sure.  But do you need also `crc32c_table_addr`?  And I don't see initialization. Can you prepare full patch for JVMCI which I can integrate?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26434#discussion_r2228817259