RFR: 8359064: Expose reason for marking nmethod non-entrant to JVMCI client [v2]
Doug Simon
dnsimon at openjdk.org
Wed Jun 11 07:53:29 UTC 2025
On Wed, 11 Jun 2025 00:05:47 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> We recently introduced a way to set the reason why a nmethod was being marked as `not entrant`, see [here](https://github.com/openjdk/jdk/pull/23980) and [here](https://github.com/openjdk/jdk/pull/25338).
>>
>> This PR is to expose in the JVMCI interface the reason why the nmethod was flagged as `not entrant`. This will allow JVMCI-based compilers to implement heuristics to handle re-compilations differently based on what happened to earlier versions of a method, for instance, this will likely be used to address this [RFE in Truffle](https://github.com/oracle/graal/issues/11045
>> ).
>>
>> Tested on Linux x86_64, ARM with JTREG tier 1-3.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>
> Address PR feedback: add comments, refactor enum definition in the Java side.
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/InstalledCode.java line 152:
> 150: */
> 151: public void invalidate() {
> 152: invalidate(true, 0);
This assigns `ChangeReason::C1_codepatch` to JVMCI invalidations which does not seem right.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25706#discussion_r2139454968
More information about the graal-dev
mailing list