RFR: 8359064: Expose reason for marking nmethod non-entrant to JVMCI client [v5]
Doug Simon
dnsimon at openjdk.org
Thu Jun 12 19:55:31 UTC 2025
On Thu, 12 Jun 2025 19:40:13 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> We recently introduced a way to set the reason why a nmethod was being marked as `not entrant`, see [here](https://github.com/openjdk/jdk/pull/23980) and [here](https://github.com/openjdk/jdk/pull/25338).
>>
>> This PR is to expose in the JVMCI interface the reason why the nmethod was flagged as `not entrant`. This will allow JVMCI-based compilers to implement heuristics to handle re-compilations differently based on what happened to earlier versions of a method, for instance, this will likely be used to address this [RFE in Truffle](https://github.com/oracle/graal/issues/11045
>> ).
>>
>> Tested on Linux x86_64, ARM with JTREG tier 1-3.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename 'reasons' enum. Adjust default value for invalidationReason.
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotNmethod.java line 225:
> 223:
> 224: private static int unknownInvalidationReason() {
> 225: return HotSpotJVMCIRuntime.runtime().config.getConstant("nmethod::ChangeReason::Unknown", Integer.class);
`unknownInvalidationReason` -> `jvmciInvalidationReason`
`"nmethod::ChangeReason::Unknown"` -> `"nmethod::InvalidationReason::JVMCI_INVALIDATE"`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25706#discussion_r2143540862
More information about the graal-dev
mailing list