RFR: 8359064: Expose reason for marking nmethod non-entrant to JVMCI client [v6]

[Cesar Soares Lucas]

On Fri, 13 Jun 2025 20:02:58 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some remaining renames.
>
> src/hotspot/share/code/nmethod.cpp line 2125:
> 
>> 2123:   JVMCINMethodData* nmethod_data = jvmci_nmethod_data();
>> 2124:   if (nmethod_data != nullptr) {
>> 2125:     nmethod_data->invalidate_nmethod_mirror(this, is_cold() ? nmethod::InvalidationReason::GC_UNLINKING_COLD : nmethod::InvalidationReason::GC_UNLINKING);
> 
> So then this is the heart of what you're after?  Maybe `GC_UNLINKING_COLD` should be `COLD_UNLOADING`?  GC is doing it but it's not for GC reasons.  `GC_UNLINKING` might better be `GC_UNLOADING`.  I don't think the `nmethod::unlink` name is a good one to propagate into enum names.
> 
> `is_cold` isn't completely reliable here as an method could both have dead oops and be cold.  I guess that probably doesn't matter though.

I'll do the renaming, good point there.

> is_cold isn't completely reliable here as an method could both have dead oops and be cold. I guess that probably doesn't matter though.

I don't think that matter because since the nmethod is cold right now it could have been eliminated for that reason at any moment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25706#discussion_r2146059210