RFR: 8359064: Expose reason for marking nmethod non-entrant to JVMCI client [v6]
Cesar Soares Lucas
cslucas at openjdk.org
Mon Jun 16 22:22:48 UTC 2025
On Mon, 16 Jun 2025 17:00:49 GMT, Tom Rodriguez <never at openjdk.org> wrote:
>> I see, thank you for the catch! I'm not sure how I can detect this case. My first idea was to just check if the "invalidationReason" field is already set or not, but looks like in order to do that I'd need to wrap the `nmethod_mirror` in a `JVMCIObject`. Unfortunately, there is a comment just a few lines above this change saying to _not_ do this wrapping. I'm not quite familiar with all nmethod state transitions. Would it be sufficient to just add a check for whether the nmethod is already non-entrant on line 818?
>
> You should be able to use `HotSpotJVMCI::HotSpotNmethod::get_invalidationReason`. JVMCIObject handles dispatching if you don't know which runtime you are attached to but we know we are talking to HotSpot.
Thank you for clarifying. I just pushed a change addressing your comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25706#discussion_r2150991011
More information about the graal-dev
mailing list