RFR: 8359227: Code cache/heap size options should be size_t [v4]

Thomas Schatzl tschatzl at openjdk.org
Wed Jun 18 17:25:32 UTC 2025


On Wed, 18 Jun 2025 17:05:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change that makes the various code cache/heap size options
>> consistently be of type size_t.
>> 
>> The shared declarations for these options were all uintx. These options all
>> may have platform-defined values. Some of those platform-specific definitions
>> were uintx, some were size_t, and some were intx(!). This change makes them
>> all consistently size_t.
>> 
>> More details in the first comment.
>> 
>> Testing: mach5 tier1-6
>> GHA testing in-progress
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'master' into code-cache-sizes
>  - Merge branch 'master' into code-cache-sizes
>  - update copyrights
>  - remove leftover <type_traits> include
>  - fix whitebox access to code cache size configs
>  - VMPageSizeConstraintFunc
>  - CodeCacheMinBlockLength
>  - CodeCacheExpansionSize
>  - various CodeHeapSize options
>  - CodeCacheMinimumUseSpace
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/984d7f9c...56471cc9

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25791#pullrequestreview-2940105073


More information about the graal-dev mailing list