RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v12]
Vladimir Ivanov
vlivanov at openjdk.org
Tue May 6 01:33:21 UTC 2025
On Mon, 5 May 2025 03:54:24 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> I prefer explicit accessor calls on corresponding instance fields.
>>
>> It's confusing to see `VM_Version::CpuidInfo::feature_flags()` implicitly modifying `_dynamic_features_vector` through macros.
>
> I have changed this local rountine name to install_feature_flags to confirm to its semantics
It's still counter-intuitive to see `VM_Version::CpuidInfo` implicitly initializes a field in `Abstract_VM_Version` class. I prefer original code shape. Any problems with the following code shape?
VM_Features VM_Version::CpuidInfo::feature_flags() const {
VM_Features result;
if (std_cpuid1_edx.bits.cmpxchg8 != 0) {
result.set_feature(CPU_CX8);
}
...
return result;
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2074474099
More information about the graal-dev
mailing list