RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v13]

Jatin Bhateja jbhateja at openjdk.org
Tue May 6 08:49:58 UTC 2025


On Tue, 6 May 2025 00:57:29 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolutions
>
> src/hotspot/cpu/x86/vm_version_x86.hpp line 707:
> 
>> 705:   //
>> 706:   static bool supports_cpuid()        { return _features  != 0; }
>> 707:   static bool supports_cmov()         { return (_features & CPU_CMOV) != 0; }
> 
> Since you touch this code anyway, I suggest to use this opportunity to automatically derive this code using  `CPU_FEATURE_FLAGS` macro. (As an example [1].)
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/vm_version_aarch64.hpp#L147

Unlike AARCH64, there is not a 1:1 mapping b/w CPU_* features and the corresponding support checkers; some AVX512 checkers use multiple features. Skipping this for now for consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2075012161


More information about the graal-dev mailing list