RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v14]

Jatin Bhateja jbhateja at openjdk.org
Tue May 6 12:09:21 UTC 2025


On Tue, 6 May 2025 11:47:47 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   build fixes for non-x86 targets
>
> src/hotspot/cpu/x86/vm_version_x86.hpp line 37:
> 
>> 35: class VM_Features {
>> 36:  public:
>> 37:   using FeatureVector = uint64_t [MAX_FEATURE_VEC_SIZE];
> 
> Do you think it would be better to refactor this into a separate class analogous to `std::bitset`? You can start with only implementing `test`, `set`, `reset`. This would help in other use cases, too.
> 
> https://en.cppreference.com/w/cpp/utility/bitset

In essence, what we have currently is a bitmap implementation, but its utility is limited to VM_Version for now. The current approach simplifies the JVMCI side of handling. We have an existing utility for bitset src/hotspot/share/utilities/bitMap.hpp

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2075325468


More information about the graal-dev mailing list