RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v15]
Vladimir Ivanov
vlivanov at openjdk.org
Wed May 7 21:53:59 UTC 2025
On Wed, 7 May 2025 15:28:09 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Making _features_bitmap size configurable
>> - cleanups & refactorings
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotJVMCIBackendFactory.java line 121:
>
>> 119: long featureIndex = bitIndex >>> featuresElementShiftCount;
>> 120: long featureBitMask = 1L << (bitIndex & featuresElementMask);
>> 121: assert featureIndex < featuresBitMapSize;
>
> `featuresBitMapSize` is size in bytes while `featureIndex` is index to long array
Good catch, Yudi.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2078544595
More information about the graal-dev
mailing list