RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v18]
Sandhya Viswanathan
sviswanathan at openjdk.org
Fri May 9 00:03:58 UTC 2025
On Thu, 8 May 2025 19:21:31 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> - Intel AVX10[1] extends and enhances the capabilities of Intel AVX-512 to benefit all Intel® products and will be the vector ISA of choice moving into the future.
>> - It supports a new ISA versioning scheme which simplifies the existing AVX512 feature enumeration scheme. Feature set supported by an AVX10 ISA version will be supported by all the versions above it.
>> - The initial, fully-featured version of Intel® AVX10 will be enumerated as Version 2 (denoted as Intel® AVX10.2). This will include the new ISA extension over the existing AVX512 instructions.
>> - An early version of Intel® AVX10 (Version 1, or Intel® AVX10.1) that only enumerates the Intel® AVX-512 instruction set at 128, 256, and 512 bits will be enabled on the Granite Rapids Server for software pre-enabling.
>>
>> This patch adds the necessary CPUID feature detection for AVX10 ISA version 1 and 2. In terms of architectural state save restoration, AVX10 is isomorphic to AVX512 support up till Granite Rapids. State components affected by AVX10 extension include SSE, AVX, Opmask, ZMM_Hi256, and Hi16_ZMM registers.
>>
>> The patch has been regressed through tier1 and jvmci tests
>>
>> Please review and share your feedback.
>>
>> Best Regards,
>> Jatin
>>
>> [1] https://www.intel.com/content/www/us/en/content-details/844829/intel-advanced-vector-extensions-10-2-intel-avx10-2-architecture-specification.html
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressing Yudi's comments
test/hotspot/jtreg/serviceability/sa/ClhsdbLongConstant.java line 108:
> 106: checkLongValue("VM_Version::CPU_SHA ",
> 107: longConstantOutput,
> 108: 34L);
Need to change the comment on line 94 as well.
test/lib-test/jdk/test/whitebox/CPUInfoTest.java line 69:
> 67: "f16c", "pku", "ospke", "cet_ibt",
> 68: "cet_ss", "avx512_ifma", "serialize", "avx_ifma",
> 69: "apx_f", "avx10_1", "avx10_2"
A minor nit, in between spacing could match previous statement.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2080650055
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2080648091
More information about the graal-dev
mailing list