RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v19]
Jatin Bhateja
jbhateja at openjdk.org
Fri May 9 23:36:17 UTC 2025
On Fri, 9 May 2025 22:23:41 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits:
>>
>> - Sandhya's review comments resoultion
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8352675
>> - Addressing Yudi's comments
>> - Code re-factoring from Vladimir
>> - Reveiw suggestions incorporated
>> - Making _features_bitmap size configurable
>> - cleanups & refactorings
>> - build fixes for non-x86 targets
>> - Review comments resolutions
>> - Updating comment
>> - ... and 9 more: https://git.openjdk.org/jdk/compare/411a63ea...f583a521
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1052:
>
>> 1050: if (is_intel()) { // Intel cpus specific settings
>> 1051: if (is_knights_family()) {
>> 1052: _features.clear_feature(CPU_VZEROUPPER);
>
> Should we be also clearing the CPU_AVX10_1 and CPU_AVX10_2 here?
I agree; it may help validate KNL on Diamond Rapids :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2082628062
More information about the graal-dev
mailing list