RFR: 8345826: Do not automatically resolve jdk.internal.vm.ci when libgraal is used [v2]
Doug Simon
dnsimon at openjdk.org
Fri May 16 13:16:30 UTC 2025
On Fri, 16 May 2025 09:30:42 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>>> Depends if you care as much about VM startup when using libgraal as when using C2. Is there a reason why only one of these should have AOTClassLinking startup benefits?
>>
>> I should have been clearer, my question/comment was about the no-libgraal case, not the libgraal case. With the proposed change, I think you are looking to print an error. I'm wondering why it can't continue to add jdk.internal.vm.ci to the set of root modules.
>
> Ok, that's a good suggestion. I'll explore further.
>
> And I now understand your first comment about "+EnableJVMCI and libgraal is all good" is in the context of having applied this PR. In that context, the set of modules in the training run is indeed the same as the production run.
I've pushed a commit that implements your suggestion and reduces the size of the overall change nicely. More importantly, I think it's a better design - thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25240#discussion_r2093025755
More information about the graal-dev
mailing list