RFR: 8345826: Do not automatically resolve jdk.internal.vm.ci when libgraal is used [v6]
Fabio Niephaus
fniephaus at openjdk.org
Mon May 19 07:46:23 UTC 2025
On Mon, 19 May 2025 07:26:01 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> src/hotspot/share/jvmci/jvmciRuntime.hpp line 38:
>>
>>> 36: #endif // INCLUDE_G1GC
>>> 37:
>>> 38: #define JVMCI_NOT_ENABLED_ERROR_MESSAGE "JVMCI is not enabled. Must specify '--add-modules=jdk.internal.vm.ci' or '-XX:+EnableJVMCI' to the java launcher."
>>
>> It's the exception message for an InternalError so maybe this is okay but in general I don't think you want to be asking users to have to name a JDK internal module.
>
> I think anyone using a non-standard configuration for Graal would not be surprised about JVMCI and would actually appreciate the extra hint when they get things "wrong".
Assuming we want users to use `-XX:+EnableJVMCI` over `--add-modules=jdk.internal.vm.ci` for said reason, maybe flip the order?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25240#discussion_r2095053343
More information about the graal-dev
mailing list