RFR: 8334717: Add JVMCI support for APX EGPRs

Doug Simon dnsimon at openjdk.org
Mon May 19 15:26:53 UTC 2025


On Mon, 19 May 2025 15:16:27 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/RegisterAttributes.java line 58:
>> 
>>> 56:      *         element at index i holds the attributes of the register whose number is i.
>>> 57:      */
>>> 58:     public static RegisterAttributes[] createMap(RegisterConfig registerConfig, List<Register> registers) {
>> 
>> We should remove raw arrays as much as possible in JVMCI and replace them with immutable Lists:
>> 
>>      * @return an immutable list whose length is the max register number in {@code registers} plus 1. An
>>      *         element at index i holds the attributes of the register whose number is i.
>>      */
>>     public static List<RegisterAttributes[] createMap(RegisterConfig registerConfig, List<Register> registers) {
>
> I have audited all the .clone() on array objects and changed as much as possible. Let me know if there is still some opportunity

Looks good - thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23159#discussion_r2095973654


More information about the graal-dev mailing list