RFR: 8357581: [JVMCI] Add HotSpotProfilingInfo

Vladimir Kozlov kvn at openjdk.org
Thu May 22 22:01:57 UTC 2025


On Thu, 22 May 2025 17:12:34 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> Graal is adding enhanced logic to detect deoptimization cycles and needs to be able to query a method's decompilation counter (i.e. `MethodData::_compiler_counters._nof_decompiles`).
> This PR adds the `HotSpotProfilingInfo` interface so that such HotSpot-specific profiling info can be accessed.
> The change looks bigger in the GitHub review UI than it really is. I have simply renamed the pre-existing `HotSpotProfilingInfo` private class as `HotSpotProfilingInfoImpl` and repurposed the `HotSpotProfilingInfo` name for the *new* public interface.

Just one cosmetic comment about copyright year.

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotProfilingInfo.java line 2:

> 1: /*
> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.

Please, keep 2 years: 2012, 2025. Even if you changed content the file is still present.

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotProfilingInfoImpl.java line 2:

> 1: /*
> 2:  * Copyright (c) 2012, 2025, Oracle and/or its affiliates. All rights reserved.

this is one is fine since you copied it from an other file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25397#pullrequestreview-2862651511
PR Review Comment: https://git.openjdk.org/jdk/pull/25397#discussion_r2103452147
PR Review Comment: https://git.openjdk.org/jdk/pull/25397#discussion_r2103452864


More information about the graal-dev mailing list